Port #[no_implicit_prelude] to the new attribute parsing infrastructure
#143237
+77
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
rustbot
added
the
S-waiting-on-review
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_attr_data_structures |
JonathanBrouwer
force-pushed
the
no_implicit_prelude_parser
branch
2 times, most recently
from
5172406 to
a96330e
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 1, 2025
Rollup of 12 pull requests Successful merges: - #136801 (Implement `Random` for tuple) - #141867 (Describe Future invariants more precisely) - #142760 (docs(fs): Touch up grammar on lock api) - #143181 (Improve testing and error messages for malformed attributes) - #143210 (`tests/ui`: A New Order [19/N] ) - #143212 (`tests/ui`: A New Order [20/N]) - #143230 ([COMPILETEST-UNTANGLE 2/N] Make some compiletest errors/warnings/help more visually obvious) - #143240 (Port `#[rustc_object_lifetime_default]` to the new attribute parsing …) - #143255 (Do not enable LLD by default in the dist profile) - #143262 (mir: Mark `Statement` and `BasicBlockData` as `#[non_exhaustive]`) - #143269 (bootstrap: make comment more clear) - #143279 (Remove `ItemKind::descr` method) Failed merges: - #143237 (Port `#[no_implicit_prelude]` to the new attribute parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup
JonathanBrouwer
force-pushed
the
no_implicit_prelude_parser
branch
from
a96330e to
f793856
Compare
|
^ Rebased because of conflicts |
|
@bors r+ rollup |
|
Another candidate for #142964, nice |
JonathanBrouwer
force-pushed
the
no_implicit_prelude_parser
branch
from
f793856 to
e27211a
Compare
rustbot
added
the
S-waiting-on-review
|
@bors r+ rollup |
bors
removed
the
S-waiting-on-review
This was referenced Jul 3, 2025
|
@bors rollup=never |
|
seems surprisingly conflicty 🤷 |
bors
added a commit
that referenced
this pull request
Jul 3, 2025
Rollup of 6 pull requests Successful merges: - #134006 (setup typos check in CI) - #142876 (Port `#[target_feature]` to new attribute parsing infrastructure) - #143038 (avoid suggesting traits from private dependencies) - #143083 (Fix rustdoc not correctly showing attributes on re-exports) - #143283 (document optional jobs) - #143329 (minicore: use core's `diagnostic::on_unimplemented` messages) Failed merges: - #143237 (Port `#[no_implicit_prelude]` to the new attribute parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup
|
☔ The latest upstream changes (presumably #143363) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
…ture Signed-off-by: Jonathan Brouwer <[email protected]>
JonathanBrouwer
force-pushed
the
no_implicit_prelude_parser
branch
from
e27211a to
fee5e3c
Compare
|
^ Rebased (again :P) on master |
rustbot
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors r=jdonszelmann,oli-obk |
|
💡 This pull request was already approved, no need to approve it again.
|
|
No attr prs in the queue, back to @bors rollup=iffy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports no_implicit_prelude to the new attribute parsing infrastructure for #131229 (comment)
r? @oli-obk
cc @jdonszelmann